Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Modify Snowflake parse_json macro usage #441

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[FIX] Modify Snowflake parse_json macro usage #441

merged 2 commits into from
Sep 20, 2024

Conversation

llifoawing
Copy link
Member

@llifoawing llifoawing commented Aug 16, 2024 •
edited
Loading

Overview

Modifies the Snowflake parse_json macro to use try in case json is invalid.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Resolves [Bug]: Parsing Error in dbt Artifacts JSON Conversion of Source with Case-Sensitive Column Names in Filters for dbt freshness #419

Outstanding questions

NA

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 16, 2024 23:56 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 16, 2024 23:56 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 16, 2024 23:57 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 16, 2024 23:57 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 17, 2024 00:00 — with GitHub Actions Inactive
@michelley-an
Copy link
Contributor

I wonder if the version has to be updated again to 2.6.5

@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:18 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:18 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:18 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:18 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests September 20, 2024 16:21 — with GitHub Actions Inactive
@llifoawing llifoawing merged commit 5e824d2 into main Sep 20, 2024
22 checks passed
@llifoawing llifoawing deleted the bugfix/fix-parsing-error-for-invalid-json branch September 20, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelley-an michelley-an michelley-an approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llifoawing @michelley-an